Re: [Qemu-block] [PATCH v2 4/7] block: remove extra condition in bdrv_can_write_zeroes_with_unmap

[John Snow]

On 07/07/2016 05:35 AM, Denis V. Lunev wrote:
> All nowadays .bdrv_co_write_zeroes callbacks could perfectly work even
> with backing store attached. If future new callbacks will unable to do
> that - they have a chance to block this in bdrv_get_info().
> 

Seems reasonable to me.

> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Eric Blake <address@hidden>
> ---
>  block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block.c b/block.c
> index 823ff1d..c2fb8bd 100644
> --- a/block.c
> +++ b/block.c
> @@ -2834,7 +2834,7 @@ bool bdrv_can_write_zeroes_with_unmap(BlockDriverState 
> *bs)
>  {
>      BlockDriverInfo bdi;
>  
> -    if (bs->backing || !(bs->open_flags & BDRV_O_UNMAP)) {
> +    if (!(bs->open_flags & BDRV_O_UNMAP)) {
>          return false;
>      }
>  
> 

Reviewed-by: John Snow <address@hidden>