Re: [Qemu-devel] Updated BGR vs. RGB vga patch...

[Leonardo E. Reiter]

Actually it should probably be made conditionally compiled for now, 
until the VGA architecture changes to something more efficient.  Would 
you agree with that?  That way, people who know they will need the hack 
can enable it at configure/compile time, and the rest will not be affected.

How does that sound?  I'd be happy to post an updated patch that does that.

- Leo

Paul Brook wrote:
> On Monday 10 April 2006 17:25, Leonardo E. Reiter wrote:
>
> > Hello,
> >
> > attached is an updated version (against today's CVS) of a patch to
> > enable B/G/R color encoding rather than R/G/B with the command-line
> > option -bgr.  I found the original here (post by Martin Bochnig):
>
>
> Shouldn't we be able to figure this out by asking SDL and/or the X server?
> Also, adding an if to the low-level conversion routines seems a bad idea for 
> performance.
>
> Paul

--
Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing from Desktop to Data Center
Main: +1 512 339 7979
Fax: +1 512 532 6501
http://www.win4lin.com