Re: [Qemu-devel] Re: PATCH, RFC: Generic DMA framework

[Fabrice Bellard]

Paul Brook wrote:
> On Friday 24 August 2007, Blue Swirl wrote:
> > I have now converted the ISA DMA devices (SB16, FDC), most PCI devices
> > and targets.
> >
> > gdma.diff: Generic DMA
> > pc_ppc_dma_to_gdma.diff: Convert x86 and PPC to GDMA
> > pc_sb16_to_gdma.diff: Convert SB16 to GDMA
> > pc_fdc_to_gdma.diff: FDC
> > pc_dma_cleanup.diff: Remove unused functions
> > sparc_gdma.diff: Convert Sparc32 to GDMA
> > sparc32_dma_esp_le_to_gdma.diff: Convert ESP and Lance
> > sun4c.diff: Preliminary Sun4c (Sparcstation-1) support
> > pci_gdma.diff: Convert PCI devices and targets
> >
> > Any comments? The patches are a bit intrusive and I can't test the
> > targets except that they compile.
>
> Shouldn't the PCI DMA object be a property of the PCI bus?
> ie. we don't want/need to pass it round as a separate parameter. It can be 
> inferred form the device/bus.

I agree. Moreover the DMA is bus specific so I don't see a need to add a 
generic DMA layer.

Regards,

Fabrice.