[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec |
Date: |
Tue, 27 May 2008 19:05:03 +0300 |
On 5/27/08, Paul Brook <address@hidden> wrote:
> > +void cpu_load_flags(CPUState *env);
> > +void cpu_put_flags(CPUState *env);
>
>
> These really need a comment saying what they do. The names are not at all
> intuitive. Also, why load/put? I'd expect load/save/store or get/put.
>
>
> > +#if defined(reg_REGWPTR)
> > +static uint32_t *saved_regwptr;
> > +#endif
>
>
> Eww. You've replaced reasonably self contained local code with a global
> variable hidden deep in target specific code. I plan on adding multithreaded
> qemu support soon, so this is a non-starter.
REGWPTR code can be removed, it's not used now.
- Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function, (continued)
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Blue Swirl, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Glauber Costa, 2008/05/27
- Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too., Fabrice Bellard, 2008/05/27
- Re: [Qemu-devel] [PATCH 2/6] Push common interrupt variables to cpu-defs.h, Fabrice Bellard, 2008/05/27
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec, Paul Brook, 2008/05/27
- Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec,
Blue Swirl <=
Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec, Fabrice Bellard, 2008/05/27