Re: [Qemu-devel] [PATCH 1/5] Re-factor nic model listing

[Jamie Lokier]

Paul Brook wrote:
> > > On Thursday 13 November 2008, Mark McLoughlin wrote:
> > >>      .desc = "ARM Versatile/PB (ARM926EJ-S)",
> > >>      .init = vpb_init,
> > >>      .use_scsi = 1,
> > >> +    .nic_models = pci_nic_models,
> > >
> > > This is wrong, an I'd expect a lot of the other non-PC machines are too.
> >
> > What's the issue?  This board seems to have a PCI bridge attached to it
> > so why can't it support any PCI nic?  Is this just not something that
> > occurs naturally?
> 
> For the same reason you mentioned separately: The abstraction is all wrong. 
> These boards also support various non-pci NICs. Admittedly this is a 
> pre-existing bug, but if we're changing things it makes sense to get it 
> right.

Doesn't it make sense to add pci_nic_models _automatically_ to any
board with a PCI interface, and have nic_models just for additional
NICs which aren't implied by having a PCI interface?

-- Jamie