[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] Use ffs in favor of ffsll
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH] Use ffs in favor of ffsll |
Date: |
Wed, 1 Jul 2009 23:27:51 +0300 |
On 7/1/09, Jan Kiszka <address@hidden> wrote:
> Not all host platforms support the ll variant. This is not a critical
> path, so go the easy way.
> - for (i = 0; i < ARRAY_SIZE(env->interrupt_bitmap); i++) {
> - bit = ffsll(env->interrupt_bitmap[i]);
> + for (i = 0; i < sizeof(env->interrupt_bitmap) / sizeof(int); i++) {
> + bit = ffs(((int *)env->interrupt_bitmap)[i]);
> if (bit) {
> - pending_irq = i * 64 + bit - 1;
> + pending_irq = i * 8 * sizeof(int) + bit - 1;
I think this will not work on a big endian host.
- [Qemu-devel] [PATCH] Use ffs in favor of ffsll, Jan Kiszka, 2009/07/01
- [Qemu-devel] Re: [PATCH] Use ffs in favor of ffsll,
Blue Swirl <=
- [Qemu-devel] Re: [PATCH] Use ffs in favor of ffsll, Jan Kiszka, 2009/07/01
- [Qemu-devel] [PATCH v2] Use ffs in favor of ffsll, Jan Kiszka, 2009/07/01
- Re: [Qemu-devel] [PATCH v2] Use ffs in favor of ffsll, Nathan Froyd, 2009/07/01
- [Qemu-devel] Re: [PATCH v2] Use ffs in favor of ffsll, Jan Kiszka, 2009/07/01
- Re: [Qemu-devel] [PATCH v2] Use ffs in favor of ffsll, Stuart Brady, 2009/07/01
- [Qemu-devel] [PATCH] Use ctz64 in favor of ffsll, Jan Kiszka, 2009/07/02
- [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll, Jan Kiszka, 2009/07/02
- Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll, Paul Brook, 2009/07/03
- Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll, Jan Kiszka, 2009/07/04
Re: [Qemu-devel] Re: [PATCH] Use ffs in favor of ffsll, Christoph Egger, 2009/07/02