Re: [Qemu-devel] [PATCH v2] Use ffs in favor of ffsll

[Nathan Froyd]

On Wed, Jul 01, 2009 at 10:55:02PM +0200, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Blue Swirl wrote:
> >> I think this will not work on a big endian host.
> > 
> > Right, may theoretically bite us once we are able to migrate between kvm
> > and tcg. Will send a better version nevertheless.
> > 
> 
> -    for (i = 0; i < ARRAY_SIZE(env->interrupt_bitmap); i++) {
> -        bit = ffsll(env->interrupt_bitmap[i]);
> +    for (i = 0; i < sizeof(env->interrupt_bitmap) / sizeof(int); i++) {
> +        /* Note: This assumes little endian host, which is true in KVM mode.
> +           In TCG mode it must be zero anyway. */
> +        bit = ffs(((int *)env->interrupt_bitmap)[i]);

ISTR that some PPC hosts support KVM...

-Nathan