[Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces

[Blue Swirl]

On 7/5/09, Michael S. Tsirkin <address@hidden> wrote:
> MSIX present bit is tested incorrectly, and only happens to work because
>  the bit we are testing is 0x1.  Add braces to fix this.
>
>  Reported-by: Blue Swirl <address@hidden>
>  Signed-off-by: Michael S. Tsirkin <address@hidden>
>  ---
>   hw/msix.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>  diff --git a/hw/msix.c b/hw/msix.c
>  index 33549f5..db72cc3 100644
>  --- a/hw/msix.c
>  +++ b/hw/msix.c
>  @@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
>   {
>      unsigned n = dev->msix_entries_nr;
>
>  -    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
>  +    if (!(dev->cap_present & QEMU_PCI_CAP_MSIX))

With the braces comment I meant that while working on the code, you
should update it to match CODING_STYLE:
if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
    return;
}