[Qemu-devel] Re: [PATCH 16/23] Port PCI Bus to VMState design

[Juan Quintela]

Gerd Hoffmann <address@hidden> wrote:
> On 08/20/09 19:42, Juan Quintela wrote:
>> This uses VARRAY and INT32_EQUAL values
>
> This is one place where I would change the code to reduce load/save
> complexity.
>
> Quick grep shows that the max value for bus->nirqs is
> 32. s/*irq_count/irq_count[32]/ for PCIBus, drop dynamic allocation
> and allways save/load 32 values.  INT32_EQUAL + VARRAY isn't needed
> then.

I agree to drop INT32_EQUAL, but maintain the VARRAY.
VARRAY is nice if there is another field in the stuct that tolds you how
many are used.

If you change the 32 number, you just need to upgrade the version.
Will do something like that.

The reason that I don't want to send the whole thing is that there are
times when we are sending tables that are empty (devices not being
used).  Having an initial size makes things go away.  And then, I will
create the VMSTATE_VARRAY() that handles the two fields in one go.

Later, Juan.

> cheers,
>   Gerd