[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 70/81] remove last 3 uses of :=, everywhere
From: |
Hollis Blanchard |
Subject: |
Re: [Qemu-devel] Re: [PATCH 70/81] remove last 3 uses of :=, everywhere else uses += or = |
Date: |
Wed, 26 Aug 2009 15:15:36 -0700 |
On Wed, Aug 26, 2009 at 2:46 PM, Juan Quintela<address@hidden> wrote:
> Hollis Blanchard <address@hidden> wrote:
>> On Mon, Aug 3, 2009 at 5:47 AM, Juan Quintela<address@hidden> wrote:
>>>
>>> Signed-off-by: Juan Quintela <address@hidden>
>>> ---
>>> Makefile.target | 6 +++---
>>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Makefile.target b/Makefile.target
>>> index a4d269d..6b3d40f 100644
>>> --- a/Makefile.target
>>> +++ b/Makefile.target
>>> @@ -20,7 +20,7 @@ endif
>>> PROGS=$(QEMU_PROG)
>>>
>>> ifeq ($(subst ppc64,ppc,$(ARCH))$(TARGET_BASE_ARCH),ppcppc)
>>> -translate.o: QEMU_CFLAGS := $(QEMU_CFLAGS) $(call cc-option,
>>> $(QEMU_CFLAGS), -fno-unit-at-a-time,)
>>> +translate.o: QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS),
>>> -fno-unit-at-a-time,)
>>> endif
>>>
>>> LIBS+=-lm
>>
>> This change breaks the build with PPC host and PPC target:
>> Makefile:25: *** Recursive variable `QEMU_CFLAGS' references itself
>> (eventually). Stop.
>>
>> I don't know why you want to remove all :=, but it seems like this
>> hunk should be reverted.
>
> Could you check two things:
>
> a- remove the whole block, it should not be needed anymore (or that I
> have been told)
The original commit, from malc, says it's necessary to work around a
gcc 4.3.0 bug. If that's true, it's probably not a great idea to
remove it.
> b- if a) don't work, tryng to change the interior bit to
>
> translate.o: QEMU_CFLAGS += $(call cc-option, $(CFLAGS),-fno-unit-at-a-time,)
>
> And if so, we can do this change. What we pass as 2nd argument
> shouldn't matter for this test.
>
> call cc-option is complicated to get right, sorry :(
If it doesn't matter, better not to pass anything, rather than confuse
the reader into thinking it does matter. This seems to work:
translate.o: QEMU_CFLAGS += $(call cc-option, , -fno-unit-at-a-time,)
But strangely, this doesn't:
translate.o: QEMU_CFLAGS += $(call cc-option, "", -fno-unit-at-a-time,)
However, what if the second argument did matter? I don't understand
the problem with the original syntax.
Debugging makefiles sucks.
-Hollis
- [Qemu-devel] [PATCH 63/81] Use only one KVM_CFLAGS, (continued)
- [Qemu-devel] [PATCH 63/81] Use only one KVM_CFLAGS, Juan Quintela, 2009/08/03
- [Qemu-devel] [PATCH 64/81] Use one less HELPER_CFLAGS, Juan Quintela, 2009/08/03
- [Qemu-devel] [PATCH 67/81] AUDIO_PT is not needed, Juan Quintela, 2009/08/03
- [Qemu-devel] [PATCH 66/81] FMOD_CFLAGS is not set when CONFIG_FMOD is undef, Juan Quintela, 2009/08/03
- [Qemu-devel] [PATCH 68/81] Generate CONFIG_AUDIO_PT_INT in configure, Juan Quintela, 2009/08/03
- [Qemu-devel] [PATCH 65/81] Make slirp include dir globlal in cflags, Juan Quintela, 2009/08/03
- [Qemu-devel] [PATCH 69/81] CONFIG_POSIX makes more sense that not CONFIG_WIN32, Juan Quintela, 2009/08/03
- [Qemu-devel] [PATCH 70/81] remove last 3 uses of :=, everywhere else uses += or =, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 71/81] Consolidate audio flags in configure, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 73/81] use TARGET_<arch name> for selection, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 72/81] We also need TARGET_<arechname> in Makefiles, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 74/81] Disable aio in mingw32, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 76/81] VDE libs are used both by tools and softmmu, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 75/81] Add libs_tools support, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 77/81] CURL libs are used both by tools and softmmu, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 79/81] convert gprof flags to style of rest of Makefile, Juan Quintela, 2009/08/03
[Qemu-devel] [PATCH 78/81] Add cocoa libs at Darwin selection time, Juan Quintela, 2009/08/03