[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [Qemu-commits] [COMMIT 733318e] don't call cpu_sychroni
From: |
Glauber Costa |
Subject: |
[Qemu-devel] Re: [Qemu-commits] [COMMIT 733318e] don't call cpu_sychronize_state from reset handlers |
Date: |
Thu, 10 Sep 2009 09:29:42 -0300 |
User-agent: |
Jack Bauer |
On Thu, Sep 10, 2009 at 02:44:04PM +0300, Avi Kivity wrote:
> On 09/10/2009 01:37 AM, Anthony Liguori wrote:
>> From: Glauber Costa<address@hidden>
>>
>> Doing this will make the vcpu ioctl be issued from the I/O thread, instead
>> of cpu thread. The correct behaviour is to call it from within the cpu
>> thread,
>> as soon as we are ready to go.
>>
>>
>
> This commit, when merged into qemu-kvm, breaks reboot and system_reset.
> I haven't checked upstream qemu (probably needs iothread enabled to have
> an effect).
Yes, unfortunately. I told anthony yesterday to drop it, as I have noticed it
myself. this relation is much more subtle, and I'll have to take a look at a
better way to solve the problem