qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race


From: Jamie Lokier
Subject: Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread"
Date: Thu, 8 Oct 2009 02:47:42 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

malc wrote:
> >     The  use of sigprocmask() is unspecified in a
> >     multithreaded process; see pthread_sigmask(3).
> > 
> > Does it matter?
> 
> One of the patches i've asked you to try today replaced sigprocmask with
> pthread_sigmask, you've said it did nothing. In any case, strictly
> speaking, the code is wrong, so yes it does matter in theory.

It won't matter on a Linux host (they are the same), but
pthread_sigmask should be used because it's Right(tm) and it could
make a difference on some other host.

-- Jamie




reply via email to

[Prev in Thread] Current Thread [Next in Thread]