Re: [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module

[malc]

On Sat, 17 Oct 2009, Paolo Bonzini wrote:

> On 10/16/2009 11:37 PM, Anthony Liguori wrote:
> > 
> > I already am :-)  Stay tuned, I should have a patch later this afternoon.
> 
> Was it a race?  (Seriously, sorry I didn't notice a couple of hours ago).
> 
> This one is ~5% slower than the "Evil" one, but half the size.  Tested against
> the comments.json file from the "Evil" parser and with valgrind too.  Does all
> the funky Unicode stuff too.
> 

Just from cursory glance:

a. allocation can fail
b. strtod is locale dependent

-- 
mailto:address@hidden