Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

[malc]

On Sat, 31 Jul 2010, Blue Swirl wrote:

> On Sat, Jul 31, 2010 at 4:23 PM, malc <address@hidden> wrote:
> > History has shown that this particular rule is unenforcable.
> >
> > Signed-off-by: malc <address@hidden>
> > ---
> >  CODING_STYLE |   11 ++++++-----
> >  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> Not again:
> http://lists.nongnu.org/archive/html/qemu-devel/2009-12/msg00484.html

I'm not yet senile enough to forget that, let me quote some:

"By picking a single coding style we've pretty much guaranteed that most 
people will disagree with some of it. IMO consistency is more important."

We don't have consistency, people, myself included (which was a suprise),
keep applying patches that break things in this particular regard, it
should just go.

> 
> There are plenty of ways to make the rule enforceable, for example we
> could agree to start to revert commits which introduce new
> CODING_STYLE violations.
> 

There might be plenty of ways, but none were/are used, we somehow
managed to enforce tab rule, but the braces remain elusive.

-- 
mailto:address@hidden