Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

[Aurelien Jarno]

On Sat, Jul 31, 2010 at 08:23:55PM +0000, Blue Swirl wrote:
> On Sat, Jul 31, 2010 at 4:23 PM, malc <address@hidden> wrote:
> > History has shown that this particular rule is unenforcable.
> >
> > Signed-off-by: malc <address@hidden>
> > ---
> >  CODING_STYLE |   11 ++++++-----
> >  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> Not again:
> http://lists.nongnu.org/archive/html/qemu-devel/2009-12/msg00484.html
> 
> There are plenty of ways to make the rule enforceable, for example we
> could agree to start to revert commits which introduce new
> CODING_STYLE violations.
> 

It seems to be possible to add a pre-applypatch script to the git hook
directory, that will verify the commit and reject it if it doesn't
comply with the coding rules. Of course it's possible to commit a patch
anyway by using --no-verify.

The good point of this approach is that the rule is enforced by a
script, which is not suppose to make mistakes, and that it can be shared
between patch submitters and patch committers: both side can make
mistakes and it is always better to know that as early as possible.

Of course someone as to translate the coding rules in a set of regular
expressions able to catch errors.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net