[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] [RESEND] [REBASE] Auto-document qdev device
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] [RESEND] [REBASE] Auto-document qdev devices |
Date: |
Mon, 10 Jan 2011 15:50:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Amit Shah <address@hidden> writes:
> Hello,
>
> This is yet another rebase of the patchset I'd sent earlier.
>
> Changes:
> - fixups and new strings for the bootorder patches
> - new string for the discard property for block devices.
>
> The usual notes apply: this is just the start, just getting the
> framework in place and a few examples so that people can then pick up
> and start documenting their devices and options. We want to see all
> of the devices covered, and hopefully turn on build_bug_on() on an
> empty doc string.
>
> Maintainers should perhaps also look for patches that introduce
> options without documentation.
>
> That's the long-term goal (over 0.14). For short-term, I'll be
> preparing follow-on patches that add doc strings for a few more
> options and perhaps bug people based on git history as to what
> documentation is to be added for some options.
>
> The earlier this patchset goes in the better since it'll reduce
> conflicts and rebases needed.
>
> If this looks acceptable, please apply!
This has been stuck since forever. No idea why, it's neither hairy nor
controversial.
Quoting from my review of v2(?) last September:
For QMP, we'll need to cover more than just device properties, and
in more detail than just a help text, but this looks like a sensible
step forward.
I'm fine with committing it as is. We can polish in follow-up commits.