Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1

[Anthony Liguori]

On 01/21/2011 08:51 PM, Chunqiang Tang wrote:
> > > -void qemu_bh_schedule(QEMUBH *bh)
> > > -{
> > > -    bh->cb(bh->opaque);
> > > -}
> > > -
> > > -void qemu_bh_cancel(QEMUBH *bh)
> > > -{
> > > -}
> > > -
> > > -void qemu_bh_delete(QEMUBH *bh)
> > > -{
> > > -    qemu_free(bh);
> > > -}
> > > -
> > >    int qemu_set_fd_handler2(int fd,
> > >                             IOCanReadHandler *fd_read_poll,
> > >                             IOHandler *fd_read,
> > >
> > >        
> > These functions surely cannot just be deleted like this.
> >      
> These functions were not deleted but instead moved into a separate file
> qemu-tool-time.c, because those functions are time related and the
> implementations are different in the simulation mode and in the real mode.
> In the latest patches, these functions are kept in qemu-tool.c but their
> implementations support both cases based on a switch.
>    

I think the root of the problem is that your series didn't maintain 
bisectability.

IOW, each patch needs to be able to be applied one at a time such that 
at each point, the build doesn't break and functionality doesn't break.

Otherwise, tools like git bisect don't work.

Regards,

Anthony Liguori