[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ehci: Fix unused-but-set-variable warning
From: |
David Ahern |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ehci: Fix unused-but-set-variable warning |
Date: |
Wed, 01 Jun 2011 09:53:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 |
On 06/01/2011 06:56 AM, Christophe Fergeau wrote:
> @@ -1134,11 +1128,8 @@ static int ehci_process_itd(EHCIState *ehci,
>
> DPRINTF("ISOCH: buffer %08X len %d\n", ptr, len);
>
> - if (!dir) {
> + if (!dir)
> cpu_physical_memory_rw(ptr, &ehci->buffer[0], len, 0);
> - pid = USB_TOKEN_OUT;
> - } else
> - pid = USB_TOKEN_IN;
>
> ret = USB_RET_NODEV;
>
I think you want those to be ehci->pid instead of deleting them.
David