[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach |
Date: |
Tue, 26 Jul 2011 15:06:29 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Wed, Jul 20, 2011 at 06:24:25PM +0200, Markus Armbruster wrote:
> BlockDriverState member buffer_alignment is initially 512. The device
> model may set them, with bdrv_set_buffer_alignment(). If the device
> model gets detached (hot unplug), the device's alignment is left
> behind. Only okay because device hot unplug automatically destroys
> the BlockDriverState. But that's a questionable feature, best not to
> rely on it.
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>
- Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h, (continued)
[Qemu-devel] [PATCH 50/55] block: New bdrv_set_buffer_alignment(), Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 52/55] block: Move BlockDriverAIOCB & friends from block_int.h to block.h, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 38/55] scsi-disk: Preserve tray state on migration, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach, Markus Armbruster, 2011/07/20
- Re: [Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach,
Christoph Hellwig <=
[Qemu-devel] [PATCH 37/55] ide/atapi: Preserve tray state on migration, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 41/55] fdc: Make media change detection more robust, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 30/55] block: Rename bdrv_set_locked() to bdrv_lock_medium(), Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 42/55] block: Clean up bdrv_flush_all(), Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 35/55] scsi-disk: Avoid physical/virtual tray state mismatch, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 45/55] block: Clean up remaining users of "removable", Markus Armbruster, 2011/07/20