[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h |
|
Date: |
Fri, 29 Jul 2011 15:11:46 +0200 |
|
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Fri, Jul 29, 2011 at 10:56:07AM +0200, Markus Armbruster wrote:
> > Hmm. We already do proper read-modify-write cycles for actual data
> > transfers, so killing the buffer inside SD sounds like the better
> > idea. qemu_blockalign really should be used only for block-layer internal
> > allocations.
>
> What about the uses in scsi-disk.c and ide/core.c?
They are allocating internal bounce buffers due to suboptimal I/O
models. But given that this is the reality in multiple qemu drivers I
think I'll give up and ack the move.
- Re: [Qemu-devel] [PATCH 19/55] scsi-disk: Factor out scsi_disk_emulate_start_stop(), (continued)
- [Qemu-devel] [PATCH 50/55] block: New bdrv_set_buffer_alignment(), Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 52/55] block: Move BlockDriverAIOCB & friends from block_int.h to block.h, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 38/55] scsi-disk: Preserve tray state on migration, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 37/55] ide/atapi: Preserve tray state on migration, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 41/55] fdc: Make media change detection more robust, Markus Armbruster, 2011/07/20