Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify "drive is suitable for microdrive" test

[Kevin Wolf]

Am 09.08.2011 13:56, schrieb Markus Armbruster:
> bdrv_is_locked() is about the frontend's media lock.  To make this more
> obvious, my PATCH 29/55 replaces it by bdrv_dev_is_medium_locked().  It
> does *not* query the backend's lock (which may not even exist!) set by
> bdrv_set_locked().

This sounds wrong (the behaviour, not your analysis). Do you plan to
remove bdrv_dev_is_medium_locked() as well? It is used by IDE and
scsi-disk (easy to replace) and in eject_device() in blockdev.c. Maybe
the 'eject' monitor command should be handled by another callback into
the device.

Kevin