[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/14] target-mips: Move definition of uint_fast
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 05/14] target-mips: Move definition of uint_fast{8, 16}_t to osdep.h |
Date: |
Mon, 16 Jan 2012 12:21:02 +0000 |
On 16 January 2012 12:13, Andreas Färber <address@hidden> wrote:
> Am 16.01.2012 12:38, schrieb Peter Maydell:
>> On 16 January 2012 00:46, Andreas Färber <address@hidden> wrote:
>>> +#if defined(CONFIG_SOLARIS) && CONFIG_SOLARIS_VERSION < 10
>>> +/* uint_fast8_t and uint_fast16_t not in <sys/int_types.h> */
>>> +typedef unsigned char uint_fast8_t;
>>> +typedef unsigned int uint_fast16_t;
>>> +#endif
>>
>> If you make the comment say
>> /* uint_fast*_t and int_fast*_t not in <sys/int_types.h> */
>>
>> then it won't become out of date when your later patches add
>> the other types to this section.
>
> I have no clue if that is the case, I just moved it and fixed the
> comment style. But sure, I can change the comment itself as well.
Well, your later patches add more typedefs here, right? So we need
to know: either old Solaris doesn't have any of these types and we
must typedef them all (and the comment should match that), or it
is only missing the two currently noted here, in which case we don't
need to and should not add further typedefs. What we don't want is
to have a comment and code which disagree...
-- PMM
[Qemu-devel] [PATCH 06/14] softfloat: Replace uint16 type with uint_fast16_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 03/14] qemu-tool: Fix mixup of int64 and int64_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fast8_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 08/14] softfloat: Remove unused uint8 type, Andreas Färber, 2012/01/15