Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

[Lee Essen]

On 16 Mar 2012, at 12:20, Lee Essen wrote:

> 
> On 16 Mar 2012, at 12:14, Andreas Färber wrote:
> 
>> Am 16.03.2012 13:02, schrieb Lee Essen:
>>> 
>>> target_list=""
>>> 
>>> @@ -442,6 +443,7 @@ SunOS)
>>>  # have to select again, because `uname -m` returns i86pc
>>>  # even on an x86_64 box.
>>>  solariscpu=`isainfo -k`
>>> +  shell="bash"
>> 
>> Are you sure this is safe for Solaris 9+? In
>> https://bugs.launchpad.net/qemu/+bug/636315 we concluded that
>> /usr/xpg4/bin/sh were the best choice of POSIX-compliant shell provided
>> on Solaris 10. Blue's script fixes were never applied I believe…
>> 
> 
> # /usr/xpg4/bin/sh scripts/tracetool 
> scripts/tracetool: line 113: syntax error at line 126: `)' unexpected
> 
> tracetool seems to require bash … I'm happy to look at resolving that, 
> perhaps thats a better fix.
> 

slap_wrist_for_not_looking_properly++;

It looks like a bug in tracetool (unless I completely misunderstand it), that 
bash doesn't care about…

# Get the format string including double quotes for a trace event
get_fmt()
{
    puts "${1#*)}"
}

So I will cancel the first two patches … and submit a fix for this instead.

Lee.