Re: [Qemu-devel] [PATCH 2/4] qmp: emit the WAKEUP event when the guest is put to run

[Eric Blake]

On 08/09/2012 11:28 AM, Luiz Capitulino wrote:
> Today, the WAKEUP event is emitted when a wakeup _request_ is made.
> This could be the system_wakeup command, for example.
> 
> A better semantic would be to emit the event when the guest is
> already running, as that's what matters in the end. This commit does
> that change.
> 
> In theory, this could break compatibility. In practice, it shouldn't
> happen though, as clients shouldn't rely on timing characteristics of
> the events. That is, a client relying that the guest is not running
> when the event arrives may break if the event arrives after the guest
> is already running.

Yeah, no problem with that semantic change from libvirt.


> +WAKEUP
> +------
> +
> +Emitted when the guest has been waken up from S3 and is running.

grammar:

s/has been waken/has woken/

or maybe

s/has been waken up/has been awakened/

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature