qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtre


From: liu ping fan
Subject: Re: [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot
Date: Sat, 25 Aug 2012 15:05:35 +0800

On Fri, Aug 24, 2012 at 6:24 PM, Paolo Bonzini <address@hidden> wrote:
> Il 24/08/2012 11:49, Liu Ping Fan ha scritto:
>> From: Liu Ping Fan <address@hidden>
>>
>> We are not long to force to delete the obj at that place, just
>> let its refcnt handle this issue.
>
> This seems wrong.  If anything, unplug requests should propagate down
> the tree and the top device should only acknowledge it hot-unplug after
> all its children.  You are effectively surprise-removing everything
> below a bridge.
>
I had thought that the bridge's acknowledge will be the last one eject
by guest, can not assume that?  Another question is that if we got ack
for a bridge, but not for its child, then we will just leave the
bridge on the fly?

Anyway, I thought another method to work around this. Will send out it later.

Thanks and regards,
pingfan
>
> Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]