Re: [Qemu-devel] [PATCH] ignore more generated files

[Jan Kiszka]

On 2012-09-17 20:32, Mike Frysinger wrote:
> On Monday 17 September 2012 03:19:54 Jan Kiszka wrote:
>> On 2012-09-16 22:55, Mike Frysinger wrote:
>>> On Sunday 16 September 2012 16:33:15 Stefan Weil wrote:
>>>> Am 16.09.2012 22:11, schrieb Mike Frysinger:
>>>>> +libcacard/vscclient +a.out* +.gdb_history +core +gmon.out
>>>>> +*.diff +*.patch +*.rej
>>>>
>>>> IMHO .gitignore should only contain files which are generated by
>>>> a normal QEMU build.
>>>>
>>>> a.out*, .gdb_history, core, *.diff, *patch, *.rej are not QEMU
>>>> specific and should be ignored in the user's GIT configuration.
>>>
>>> these files show up a lot when doing development on qemu, hence i
>>> think they do make sense to be listed here.  it also makes things
>>> "just work" for all users rather than requiring every one to set
>>> up their local system in the same way. plus, that would conflict
>>> with repos that do want to merge these types of files (uncommon,
>>> but not unheard of as test inputs).
>>>
>>> it's not like entries in this file "cost" anything at all.
>>
>> NAK. I'd like to see what is polluting my repositories, not ignoring
>> it because that's the policy of someone else. Excluding *.rej is
>> something I would _never_ do. If they lie around somewhere, something
>> was not merged here - that's my policy.
> 
> if something wasn't merged, your git command would have told you and spit an 
> error.  same with patch.  if .rej files are showing up and you're not 
> noticing 
> at the time of patch application, it's because you're using the tools wrong.

Whichever tool I use and how need not be your worry - nor should it be
harmed by a generic .gitignore.

Jan

signature.asc
Description: OpenPGP digital signature