[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phy
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t |
Date: |
Thu, 11 Oct 2012 12:57:21 +1100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 10, 2012 at 11:17:31AM +1100, David Gibson wrote:
> On Tue, Oct 09, 2012 at 05:24:29PM +0100, Peter Maydell wrote:
> > On 9 October 2012 13:53, David Gibson <address@hidden> wrote:
> > > Well, the place I've used this (in patches yet to be posted) is saving
> > > the state of the pseries machine itself. Specifically, I use
> > > VMSTATE_TPA_EQUAL to sanity check that the restored machine has the
> > > same ram size as the saved machine.
> >
> > This doesn't sound like the sort of check that should be in
> > a specific machine model -- you should be able to rely on
> > common qemu code to handle this. (If you can't then we need
> > a check in the common code...)
>
> Hm, true. Very well, I'll drop it, and the VMSTATE_TPA patch as
> well.
Actually, turns out I had another use of these helpers. That was to
store the real page address from the ppcmeb_tlb_t structure. That
structure is used to represent TLB entries on a number of different
embedded chips, which don't all have the same physical bus width. So
target_phys_addr_t does seem like the correct type there.
Obviously I could change the type to a fixed uint64_t, but I'm not
sure if that's a better idea than bringing in the VMSTATE_TPA
helpers. Advice?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- [Qemu-devel] [0/7] vmstate extensions, David Gibson, 2012/10/09
- [Qemu-devel] [PATCH 3/7] savevm: Add VMSTATE_FLOAT64 helpers, David Gibson, 2012/10/09
- [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t, David Gibson, 2012/10/09
- Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t, Peter Maydell, 2012/10/09
- Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t, David Gibson, 2012/10/09
- Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t, Peter Maydell, 2012/10/09
- Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t, David Gibson, 2012/10/09
- Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t,
David Gibson <=
- Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t, Peter Maydell, 2012/10/11
- Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t, David Gibson, 2012/10/11
[Qemu-devel] [PATCH 1/7] savevm: Add VMSTATE_UINT64_EQUAL helpers, David Gibson, 2012/10/09
[Qemu-devel] [PATCH 2/7] savevm: Add VMSTATE_UINTTL_EQUAL helper, David Gibson, 2012/10/09
[Qemu-devel] [PATCH 5/7] savevm: Add VMSTATE_STRUCT_VARRAY_POINTER_UINT32, David Gibson, 2012/10/09
[Qemu-devel] [PATCH 7/7] savevm: Implement VMS_DIVIDE flag, David Gibson, 2012/10/09
[Qemu-devel] [PATCH 6/7] savevm: Fix bugs in the VMSTATE_VBUFFER_MULTIPLY definition, David Gibson, 2012/10/09