Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation

[Alberto Garcia]

On Tue, Jan 08, 2013 at 05:22:35PM +0100, Andreas Färber wrote:

> > Tell me if there's anything else I should change, else I can post
> > the new patches.
> 
> Haven't looked at the latest 2/2 patch yet, same might apply there.
> Otherwise no issues spotted in 1/2.

Yes, I updated both patches. Shall I resend them now or wait for more
comments?

> >> Another thing to check (could be a follow-up) is whether the
> >> initfn can be split into instance_init (e.g., pci_set_*?) and
> >> initfn.

There's only PCI code in the init function, does it make sense to
split it? And am I actually supposed to write in the PCI configuration
space from instance_init()?

Berto