Re: [Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots

[Eric Blake]

On 01/08/2013 10:12 PM, Wenchao Xia wrote:
>   This interface now return valid internal snapshots.
> 

> +Each json-object contain the following:
> +
> +- "id": unique snapshot id (json-string)
> +- "name": internal snapshot name (json-string)
> +- "vm-state-size": size of the VM state (json-int)

In bytes?  If not, document it (but bytes would be best).

> +         {
> +            "id": "2",
> +            "name": "snapshot2",
> +            "vm-state-size": 24000,

And if it IS in bytes, then this example value feels suspiciously small
(I don't know of any guest whose memory state occupies just 24000 bytes,
because the state includes RAM and you usually need several megabytes of
RAM as a minimum size).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature