Re: [Qemu-devel] [RFC V6 06/33] qcow2: Create a way to link to l2 tables when deduplicating.

[Stefan Hajnoczi]

On Wed, Feb 06, 2013 at 01:31:39PM +0100, Benoît Canet wrote:
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 8867091..95bf848 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -63,6 +63,10 @@
>  #define DEFAULT_CLUSTER_SIZE 65536
>  
>  #define HASH_LENGTH 32
> +/* indicate that the hash structure is empty and miss offset */
> +#define QCOW_FLAG_EMPTY   (1LL << 62)

QCOW_FLAG_ is too general, I'm not sure what these flags relate to.
Maybe QCOW_DEDUP_FLAG_*?

> +/* indicate that the cluster for this hash has QCOW_OFLAG_COPIED on disk */
> +#define QCOW_FLAG_FIRST   (1LL << 63)

It's easier to understand if "OFLAG_COPIED" is part of the name instead
of picking a new word ("FIRST").

Also, does this hunk belong in another patch?