Re: [Qemu-devel] [PATCH] Fix conversion between 12 hours and 24 hours modes.

[Andreas Färber]

Am 14.02.2013 12:32, schrieb Peter Maydell:
> On 14 February 2013 11:29, Andreas Färber <address@hidden> wrote:
>> Am 14.02.2013 12:11, schrieb Peter Maydell:
>>> On 14 December 2012 22:53, Antoine Mathys <address@hidden> wrote:
>>>> The proper mapping between 24 hours and 12 hours modes is:
> [snip]
> 
>>> (and I've had confirmation from somebody that this change
>>> makes us match the hardware behaviour where AM/PM is
>>> toggled when we go from 11:59 to 12:00).
> 
>> I may be repeating myself here, but adding qtests as requested would've
>> caught this.
> 
> Er, only if the tests were testing for the right thing,
> which seems unlikely since you can't run a qtest against
> real hardware. What seems more likely is that we would
> have written a qtest which checked for the same wrong
> behaviour we incorrectly put into the code, which
> doesn't help anybody.

Still my point is we should stop accepting RTC bugfixes without test
cases or we'll never get things testable... Paolo and me can't write the
qtests for everyone, that doesn't scale.

In particular in this case the same author is touching on the other RTC
as well and refusing to supply a test case for the pre-existing
rtc-test, which is not nice.

And yes, it's always possible a test case is wrong, then it notices a
change in behavior by starting to fail and can be updated along with the
change. Remember, maintainers are supposed to run `make check`. ;)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg