Re: [Qemu-devel] [PATCH] Fix conversion between 12 hours and 24 hours modes.

[Peter Maydell]

On 14 February 2013 11:29, Andreas Färber <address@hidden> wrote:
> Am 14.02.2013 12:11, schrieb Peter Maydell:
>> On 14 December 2012 22:53, Antoine Mathys <address@hidden> wrote:
>>> The proper mapping between 24 hours and 12 hours modes is:
[snip]

>> (and I've had confirmation from somebody that this change
>> makes us match the hardware behaviour where AM/PM is
>> toggled when we go from 11:59 to 12:00).

> I may be repeating myself here, but adding qtests as requested would've
> caught this.

Er, only if the tests were testing for the right thing,
which seems unlikely since you can't run a qtest against
real hardware. What seems more likely is that we would
have written a qtest which checked for the same wrong
behaviour we incorrectly put into the code, which
doesn't help anybody.

-- PMM