qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions
Date: Thu, 21 Mar 2013 12:51:34 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4

Il 21/03/2013 11:41, Laszlo Ersek ha scritto:
> On 03/21/13 01:31, Laszlo Ersek wrote:
>> On 03/21/13 00:45, Eric Blake wrote:
>>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote:
> 
>>>> +#
>>>> +# @oem_id: #optional OEM identifier (6 bytes)
>>>
>>> s/oem_id/oem-id/
>>>
>>> In general, new QMP interfaces should use '-', not '_'.
>>
>> Indeed! I think this warrants a respin.
> 
> Actually it doesn't, apologies -- I got confused for a minute. Again,
> since I aim to match the existing option format, I must keep the same
> spelling.

We should make a list of places where we have mixed conventions, accept
both, and mass-convert to dash...

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]