[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_er
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error |
Date: |
Thu, 28 Mar 2013 15:55:49 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/28/2013 03:42 PM, Eric Blake wrote:
> On 03/28/2013 10:47 AM, Pavel Hrdina wrote:
>> Signed-off-by: Pavel Hrdina <address@hidden>
>> ---
>> qemu-img.c | 18 ++++++++++++------
>> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
>> +static int qemu_img_handle_error(Error *err)
>> +{
>> + if (error_is_set(&err)) {
>> + error_report("%s", error_get_pretty(err));
>> + error_free(err);
>> + return 1;
>
> A non-bool positive number is unusual for errors (-1, or a true/false
> scheme, tend to be more common)...
>
>> - if (error_is_set(&local_err)) {
>> - error_report("%s", error_get_pretty(local_err));
>> - error_free(local_err);
>> - return 1;
>
> ...but it is accurate code motion, so it doesn't impact my review.
And in reading 9/11, I found out why it struck me as unusual. I usually
spell it EXIT_FAILURE instead of 1, for a return status intended to be
used in a final exit() or return from main(). But that's a pre-existing
syndrome that affects much more of qemu-img.c, not worth changing here.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 00/11] convert savevm to use qapi and introduce qmp command, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 01/11] block: add error parameter to bdrv_snapshot_create() and related functions, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 02/11] block: add error parameter to del_existing_snapshots(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 04/11] savevm: add error parameter to qemu_savevm_state_iterate(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 03/11] savevm: add error parameter to qemu_savevm_state_begin(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 05/11] savevm: add error parameter to qemu_savevm_state_complete(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 06/11] savevm: add error parameter to qemu_savevm_state(), Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 08/11] qemu-img: introduce qemu_img_handle_error, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 09/11] block: update return value from bdrv_snapshot_create, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 10/11] savevm: update return value from qemu_savevm_state, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 11/11] savevm: add force parameter to HMP command and return snapshot info, Pavel Hrdina, 2013/03/28
- [Qemu-devel] [PATCH v3 07/11] qapi: Convert savevm, Pavel Hrdina, 2013/03/28