[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts.
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts. |
Date: |
Mon, 15 Apr 2013 19:06:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 15.04.2013 16:33, schrieb KONRAD Frédéric:
> On 15/04/2013 15:34, Andreas Färber wrote:
>> Am 14.04.2013 15:01, schrieb address@hidden:
>>> From: KONRAD Frederic <address@hidden>
>>>
>>> As the virtio-rng-pci and virtio-rng-s390 are switched to the new API,
>> and virtio-rng-ccw ;)
>>
>>> we can use QOM casts.
>>>
>>> Signed-off-by: KONRAD Frederic <address@hidden>
>>> ---
>>> hw/virtio/virtio-rng.c | 31 +++++++++++++++++--------------
>>> include/hw/virtio/virtio-rng.h | 2 +-
>>> 2 files changed, 18 insertions(+), 15 deletions(-)
>> Thanks,
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> I was surprised to see FOO(opaque) since we usually try to avoid it for
>> performance reasons, but it's not forbidden either.
> True, I had taken that in account but forget this series :/.
>
> Is it better to change that?
I didn't spot an obvious issue, but you know the code better than me and
should take a second look: load/save hooks should be no problem, but
there were some opaques I didn't know where they are coming from.
Andreas
>
> Thanks,
> Fred
>> Also, leaving the variable name as "s" would've spared a few lines but
>> so what. :)
>>
>> Regards,
>> Andreas
>>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v3 1/8] virtio-rng: don't use pointer for configuration., (continued)
- [Qemu-devel] [PATCH v3 1/8] virtio-rng: don't use pointer for configuration., fred . konrad, 2013/04/14
- [Qemu-devel] [PATCH v3 2/8] virtio-rng: add virtio-rng device., fred . konrad, 2013/04/14
- [Qemu-devel] [PATCH v3 3/8] virtio-rng-pci: switch to the new API., fred . konrad, 2013/04/14
- [Qemu-devel] [PATCH v3 4/8] virtio-rng-s390: switch to the new API., fred . konrad, 2013/04/14
- [Qemu-devel] [PATCH v3 5/8] virtio-rng-ccw: switch to the new API., fred . konrad, 2013/04/14
- [Qemu-devel] [PATCH v3 6/8] virtio-rng: cleanup: init and exit functions., fred . konrad, 2013/04/14
- [Qemu-devel] [PATCH v3 7/8] virtio-rng: cleanup: remove qdev field., fred . konrad, 2013/04/14
- [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts., fred . konrad, 2013/04/14
- Re: [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring., Cornelia Huck, 2013/04/15
- Re: [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring., Amit Shah, 2013/04/16