Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

[Eric Blake]

On 04/23/2013 12:26 PM, Anthony Liguori wrote:
>> There are no instructions/procedures documented on the qemu.org
>> website on how to automatically generate "Reviewed-by" signatures.
> 
> I suspect there's some confusion here.  Addressed review comments !=
> Reviewed-by.  There can always be additional comments.  Someone has to
> explicitly offer a Reviewed-by indicating that they are happy with the
> patches overall.  I've gone through the history on these patches and I
> don't see any explicit Reviewed-by's other than Eric's most recent one.

Even then, my reviewed-by tag applied only to one patch (the QMP change)
rather than the series as a whole.  But you definitely did the right
thing by pasting that in to the commit message of 10/12 on this round -
even though it is a bit of manual effort on your part, you were already
touching the rest of the series; and by adding the reviewed-by tag by
hand, it's easier for other reviewers to add additional reviews and/or
skip the patches that appear to already be adequately reviewed.

> 
> Give the series a little more time for people to look over it, it'll get
> Reviewed-bys when people are ready to offer them.

And to some extent, it's up to the maintainer of the area you are
touching to decide how many (or few) 3rd-party reviewed-by are necessary
to feel comfortable with the series.  Most maintainers like at least one
other set of eyes looking at any non-trivial patch, although I'm not
sure if there are any documented policies used by any particular
maintainer (other than qemu-trivial patches have their own wiki page for
best practices).  So far, your series has been a good cycle of posting,
response, and updating to meet the response; the fact that you are
getting comments from several people means that you are likely to get
reviewed-by from those people when they are happy with the end result
(or another round of comments on things to fix).  And if all else fails,
if you go a week without any response at all, it is generally acceptable
to ping the maintainer to ask for help in recruiting the appropriate
reviewers and/or a decision that the maintainer's review is sufficient.

Also, don't be surprised if not everyone reviews the entire series;
sometimes reviewers like myself focus only on the portion of the series
that interacts with my current interests (I tend to review anything QMP,
because I want to make sure the design will be sane for libvirt
interaction, while overlooking things like migration internals because
they are black box ops to libvirt if the interface was sane).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature