Re: [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open

[Stefan Hajnoczi]

On Tue, May 14, 2013 at 10:26:23AM +0800, Fam Zheng wrote:
> +    if (!strncmp(s->url, "http://";, strlen("http://";)) && !s->accept_range) {
> +        strncpy(state->errmsg, "Server not supporting range.", 
> CURL_ERROR_SIZE);

Please use pstrcpy(), it always NUL-terminates.  strncpy(3) does not
when the buffer size is reached.

Also, what happens when the URL is given in uppercase?
HTTP://GOOGLE.COM/