qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gi


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gitignore
Date: Thu, 22 Aug 2013 08:32:59 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 08/21/2013 01:57 AM, Laszlo Ersek wrote:
>>>> I think we could consolidate everything in tests/.gitignore. But can we
>>>> do it as an incremental patch? It's a very small cosmetic thing to respin
>>>> the series and my pull request.
>>>
>>> Sure, it's not a bug.
>> 
>> Is it OK if I submit a patch moving the test-* entries over to
>> tests/.gitignore once Anthony applies this? (I'm offering because it's
>> not clear to me who's planning to do it.)
>
> Bikeshedding alert - I personally like having a single top-level
> .gitignore for everything.  We don't live in CVS days where you had to
> have per-directory ignores, and having one file is easier to maintain
> (in the future, it's easier to know WHICH .gitignore to add a new entry
> to if there is only ONE .gitignore).  I don't care enough to write the
> patch myself, nor to care if you end up keeping the split .gitignore,
> but if I did care, I'd be consolidating in the opposite direction (move
> tests/.gitignore to the toplevel).

One more thing you probably care about (I do): everything that is
ignored in a directory should be ignored in the same .gitignore.
Trivial if the is only one.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]