[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules |
Date: |
Wed, 11 Sep 2013 16:41:38 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Sep 11, 2013 at 09:34:08PM +0800, Fam Zheng wrote:
> The converted block drivers are:
>
> curl
> iscsi
> rbd
> ssh
> glusterfs
>
> no longer adds flags and libs for them to global variables, instead
> create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is
> used as per object cflags and libs.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/Makefile.objs | 11 ++++++++++-
> configure | 33 +++++++++++++++------------------
> 2 files changed, 25 insertions(+), 19 deletions(-)
After this is applied, I can no longer use http:/// URIs with the
curl driver, if I do not build with '--enable-modules' passed to
configure.
$ ~/usr/qemu-git/bin/qemu-system-x86_64 -cdrom
http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso
qemu-system-x86_64: -cdrom
http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso:
Unknown protocol
qemu-system-x86_64: -cdrom
http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso:
could not open disk image
http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso:
No such file or directory
So it seems driver registration is broken in some way when modules aren't
enabled at compile time.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, (continued)
[Qemu-devel] [PATCH v6 5/8] configure: introduce --enable-modules, Fam Zheng, 2013/09/11
[Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install", Fam Zheng, 2013/09/11
[Qemu-devel] [PATCH v6 7/8] .gitignore: ignore module related files (dll, so, mo), Fam Zheng, 2013/09/11
[Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules, Fam Zheng, 2013/09/11
- Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules,
Daniel P. Berrange <=
Re: [Qemu-devel] [PATCH v6 0/8] Shared Library Module Support, Peter Maydell, 2013/09/11