Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

[Peter Maydell]

On 6 November 2013 14:54, Anthony Liguori <address@hidden> wrote:
> I don't think you guys understand what is happening.
>
> As ossaudio is able to be default, it *will be selected* as the audio
> output backend unconditionally.  You aren't seeing errors during
> probing, you're seeing errors post-initialization.
>
> The ossaudio init function is simply:
>
> static void *oss_audio_init (void)
> {
>     return &conf;
> }
>
> It never fails.

OK, that's a bug. (I'd misread the calling function
audio_driver_init() as also checking that the init_in
and init_out functions succeeded, which it does not.)

> So audio is broken on Linux by default today.  This
> patch unbreaks it.

No, this patch is papering over the problem by giving us
a default config where audio works for nobody.

If you want to fix that problem you need to do it by
making the oss_audio_init() function return failure
on init.

I think the major point is still the same:
 * there is a bug here
 * this patch doesn't fix it
 * this bug has been present for years
 * we should leave 1.7 behaving like 1.6 & earlier, and
   fix properly for 1.8

-- PMM