qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1
Date: Wed, 20 Nov 2013 13:02:41 +0100

On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote:
> From: Dave Airlie <address@hidden>
> 
> This is a virtio-vga device built on top of the virtio-gpu device.

Ah, I see what you use the wrapping for.  Hmm.  I think you should use a
common base class instead, i.e. something like virtio-gpu-base which
holds all the common stuff.  Both virtio-gpu and virtio-vga can use that
as TypeInfo->parent then.  This way virtio-vga doesn't have to muck with
virtio-gpu internals.  virtio-gpu-base can be tagged as abstract class
(using .abstract = true) so it will not be instantiated directly.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]