Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

[Laurent Desnogues]

On Tue, Nov 26, 2013 at 12:56 PM, Claudio Fontana
<address@hidden> wrote:
> On 09/27/2013 09:42 PM, Richard Henderson wrote:
>> On 09/26/2013 05:48 PM, Alexander Graf wrote:
>>> +    if (setflags) {
>>> +        tcg_dst = cpu_reg(dest);
>>> +    } else {
>>> +        tcg_dst = cpu_reg_sp(dest);
>>> +    }
>>
>> Never sp for logicals.
>
> This should be ok in my view, the manual explicitly shows in the pseudocode:
>
> if d == 31 && !setflags then
>  SP[] = result;
> else
>  X[d] = result;

Agreed:  for immediate logical instructions, destination can be SP
except for ANDS.  ANDS with destination as r31 is aliased to TST.


Laurent

> Claudio
>
>>
>>> +            handle_orri(s, insn);
>>
>> And yet again, a better function name.
>>
>>
>> r~
>>
>