qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configur


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration
Date: Thu, 12 Dec 2013 18:45:23 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

On 2013年12月12日 02:10, Max Reitz wrote:
Currently, the configuration of blkdebug and blkverify is done through
the "filename" alone. There is now way of manually choosing blkdebug or
blkverify as a driver and using a normal image filename.

In the case of blkdebug, the filename starts with the protocol prefix,
follows up with the name of a configuration file and ends with the name
of the image file.

In the case of blkverify, the filename starts with the protocol prefix,
follows up with the raw reference image filename and ends with the name
of the image file.

This patch allows the configuration of both drivers completely through
QMP and accordingly command-line options. The driver has to be selected
through the driver option (or similar), the image filename may be given
either as the filename itself or through a x.filename option, where "x"
depends on the driver. Further options may be required depending on the
driver.

In case of blkverify, the test image may be specified either through the
filename or as a BlockdevRef reference through the "test" option. The
raw image is referenced as "raw".

In case of blkdebug, one may either set the "config" option to the
filename of a configuration file, or the content of the configuration
file may be given directly (as options). The image filename is either
specified as the filename or referenced through the "image" option.


v3:
  - The first few patches are probably similar to the ones from the
    previous series; but it's probably best to see this series as a
    completely new one.


Reviewed the patches and also tried the test case. Looks good to me, I have only a few questions in some patches.

Thanks,
Fam




reply via email to

[Prev in Thread] Current Thread [Next in Thread]