[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src da
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns |
|
Date: |
Thu, 19 Dec 2013 11:29:11 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/17/2013 07:12 AM, Peter Maydell wrote:
> + tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2);
> + if (is_sub) {
> + tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> + } else {
> + tcg_gen_add_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> + }
Perhaps worth noticing the RA=XZR special case for the MUL alias?
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
[Qemu-devel] [PATCH 18/21] target-arm: aarch64: add support for ld lit, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 14/21] target-arm: A64: Implement minimal set of EL0-visible sysregs, Peter Maydell, 2013/12/17
[Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm, Peter Maydell, 2013/12/17