Re: [Qemu-devel] [PATCH v15 4/9] darwin: do not use -mdynamic-no-pic

[Peter Maydell]

On 13 January 2014 16:59, Paolo Bonzini <address@hidden> wrote:
> While -mdynamic-no-pic can speed up the code somewhat, it is only used
> on the legacy PowerPC Mac OS X, and I am not sure if anyone is still
> testing that.  Disabling PIC can cause problems when enabling modules,
> so do not do that.
>
> Signed-off-by: Paolo Bonzini <address@hidden>

Ccing Andreas, who I think still runs QEMU on PPC MacOSX.

Given that modules don't build on MacOSX as far as I can tell
anyway, why break PPC builds for their sake?

> ---
 >  configure |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 9d71867..99434e6 100755
> --- a/configure
> +++ b/configure
> @@ -516,8 +516,6 @@ Darwin)
>    if [ "$cpu" = "x86_64" ] ; then
>      QEMU_CFLAGS="-arch x86_64 $QEMU_CFLAGS"
>      LDFLAGS="-arch x86_64 $LDFLAGS"
> -  else
> -    QEMU_CFLAGS="-mdynamic-no-pic $QEMU_CFLAGS"
>    fi
>    cocoa="yes"
>    audio_drv_list="coreaudio"
> --
> 1.7.1

thanks
-- PMM