Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

[Fam Zheng]

On Mon, 01/13 14:15, Richard Henderson wrote:
> On 01/13/2014 08:59 AM, Paolo Bonzini wrote:
> > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak
> 
> I really really don't like random numbers that make for non-repeatable builds.
>  It's a quality-assurance nightmare.

Can you elaborate this, please?

> 
> If you want a non-random number unique to the build, try
> 
>   git log -n1 --format=format:%H
> 
> and perhaps a file containing that hash created by scripts/make-release.

What if the source code is not in a git tree, for example a tarball?

Thanks,
Fam