[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into sign bit |
Date: |
Thu, 27 Mar 2014 19:28:25 +0400 |
From: Peter Maydell <address@hidden>
Avoid undefined behaviour shifting left into the sign bit.
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/intc/xilinx_intc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c
index 4a10398..1b228ff 100644
--- a/hw/intc/xilinx_intc.c
+++ b/hw/intc/xilinx_intc.c
@@ -71,8 +71,9 @@ static void update_irq(struct xlx_pic *p)
/* Update the vector register. */
for (i = 0; i < 32; i++) {
- if (p->regs[R_IPR] & (1 << i))
+ if (p->regs[R_IPR] & (1U << i)) {
break;
+ }
}
if (i == 32)
i = ~0;
--
1.7.10.4
- [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 07/23] doc: update sun4m documentation, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 06/23] fix return check for KVM_GET_DIRTY_LOG ioctl, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 05/23] target-i386: Add missing 'static' and 'const' attributes, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 23/23] linux-user: remove duplicate statement, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into sign bit,
Michael Tokarev <=
- [Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 21/23] hw/pci-host/apb.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 10/23] target-i386: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 14/23] target-mips: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 17/23] hw/ppc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 16/23] hw/intc/openpic: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-devel] [PULL 09/23] CODING_STYLE: Section about mixed declarations, Michael Tokarev, 2014/03/27