qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into


From: Michael Tokarev
Subject: [Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into sign bit
Date: Thu, 27 Mar 2014 19:28:25 +0400

From: Peter Maydell <address@hidden>

Avoid undefined behaviour shifting left into the sign bit.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
 hw/intc/xilinx_intc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c
index 4a10398..1b228ff 100644
--- a/hw/intc/xilinx_intc.c
+++ b/hw/intc/xilinx_intc.c
@@ -71,8 +71,9 @@ static void update_irq(struct xlx_pic *p)
 
     /* Update the vector register.  */
     for (i = 0; i < 32; i++) {
-        if (p->regs[R_IPR] & (1 << i))
+        if (p->regs[R_IPR] & (1U << i)) {
             break;
+        }
     }
     if (i == 32)
         i = ~0;
-- 
1.7.10.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]