Re: [Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

[Marcel Apfelbaum]

On Mon, 2014-04-28 at 13:32 +0200, Paolo Bonzini wrote:
> Il 28/04/2014 11:38, Marcel Apfelbaum ha scritto:
> >> > Doesn't Jun's patch fix a dangling pointer?  If so, that would come
> >> > first anyway.
> > It removes pointers from a "dead" list, and it only deals with
> > some symptom.
> 
> Yeah, but dangling pointers are bad anyway.  I think we should include 
> Jun's patch.
I have nothing against it, but maybe you/someone answer this question
which I honestly don't have the answer for:
After this patch you can replace a boot-able disk at index x.
What happens if you do so and the user reboots and selects index x?
Until now, the index was 'in use', even if the disk was hot-unplugged.
What are the consequences now? If we can live with them, I am all for using 
this patch.

Thanks,
Marcel 

> 
> Paolo
> 
> > Even if you remove the device from the list, the guest still uses
> > the previous list. The only difference is that you can now
> > hot-plug/hot-unplug a disk with a boot-order index.
> > However, strange things will happen when you reboot the guest,
> > one of them may be that it actually works :)
>