[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 04/28] test: add test cases for qapi event
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V5 04/28] test: add test cases for qapi event |
Date: |
Thu, 01 May 2014 08:38:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/30/2014 10:26 PM, Wenchao Xia wrote:
> These cases will verify whether the expected qdict is built.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> tests/Makefile | 14 ++-
> tests/qapi-schema/qapi-schema-test.json | 12 ++
> tests/qapi-schema/qapi-schema-test.out | 10 +-
> tests/test-qmp-event.c | 265
> +++++++++++++++++++++++++++++++
> 4 files changed, 296 insertions(+), 5 deletions(-)
> create mode 100644 tests/test-qmp-event.c
>
> @@ -232,12 +236,16 @@ $(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json
> $(SRC_PATH)/scripts/qapi-typ
> tests/test-qapi-visit.c tests/test-qapi-visit.h :\
> $(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json
> $(SRC_PATH)/scripts/qapi-visit.py
> $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-visit.py
> $(gen-out-type) -o tests -p "test-" < $<, " GEN $@")
> +tests/test-qapi-event.c tests/test-qapi-event.h :\
> +$(SRC_PATH)/tests/qapi-schema/qapi-schema-test.json
> $(SRC_PATH)/scripts/qapi-event.py
> + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-event.py
> $(gen-out-type) -o tests -p "test-" < $<, " GEN $@")
I'd like to see LluĂs' modularization patches go in first, which means
this should be rebased to break into shorter lines and to pass the name
of the file as an input parameter rather than parsing it from stdin.
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg05069.html
But everything else here seems okay.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V5 00/28] add direct support of event in qapi schema, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 03/28] qapi script: add event support, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 01/28] os-posix: include sys/time.h, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 02/28] qapi: add event helper functions, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 04/28] test: add test cases for qapi event, Wenchao Xia, 2014/05/01
- Re: [Qemu-devel] [PATCH V5 04/28] test: add test cases for qapi event,
Eric Blake <=
- [Qemu-devel] [PATCH V5 05/28] qapi: define events in qapi schema, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 06/28] monitor: change event functions as an implemention of new emit method, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 09/28] qapi event: convert RESET, Wenchao Xia, 2014/05/01