[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 06/28] monitor: change event functions as an
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V5 06/28] monitor: change event functions as an implemention of new emit method |
Date: |
Thu, 01 May 2014 16:09:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/30/2014 10:26 PM, Wenchao Xia wrote:
> Now monitor has been hooked on the new event mechanism, so the patches
> later can convert event callers one by one. qmp_query_events() is also
> switched to use new generated event defines. Note that old function
> monitor_protocol_event() is kept for existing caller to avoid code break,
> but rate limiting is bypassed to avoid too many duplicated code. After
> convertion, the function would be removed.
s/convertion/conversion/
s/would/will/
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> monitor.c | 47 ++++++++++++++++++++++++++---------------------
> 1 files changed, 26 insertions(+), 21 deletions(-)
>
> @@ -644,7 +648,8 @@ void monitor_protocol_event(MonitorEvent event, QObject
> *data)
> }
>
> trace_monitor_protocol_event(event, event_name, qmp);
> - monitor_protocol_event_queue(event, QOBJECT(qmp));
> + /* Bypass rate limiting for now */
> + monitor_protocol_event_emit(event, QOBJECT(qmp));
> QDECREF(qmp);
I'm not quite sure I follow - is this comment evidence of something
temporarily broken for the duration of conversions, that gets fixed
later in the series; or are you breaking event rate limiting?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V5 03/28] qapi script: add event support, (continued)
- [Qemu-devel] [PATCH V5 01/28] os-posix: include sys/time.h, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 02/28] qapi: add event helper functions, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 04/28] test: add test cases for qapi event, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 05/28] qapi: define events in qapi schema, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 06/28] monitor: change event functions as an implemention of new emit method, Wenchao Xia, 2014/05/01
- Re: [Qemu-devel] [PATCH V5 06/28] monitor: change event functions as an implemention of new emit method,
Eric Blake <=
- [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 09/28] qapi event: convert RESET, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 08/28] qapi event: convert POWERDOWN, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 10/28] qapi event: convert STOP, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 11/28] qapi event: convert RESUME, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 12/28] qapi event: convert SUSPEND, Wenchao Xia, 2014/05/01
- [Qemu-devel] [PATCH V5 13/28] qapi event: convert SUSPEND_DISK, Wenchao Xia, 2014/05/01